anthony.wen/cds-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tighten ATVM git push approval gate

Browse Source
This commit is contained in:
anthony.wen
2026-03-30 15:05:23 -04:00
parent cc5eb6b7c8
commit 944a13ec26
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
atvm/AGENTS.md
View File

@@ -64,6 +64,9 @@ This file defines how to operate and maintain the ATVM workspace in `/home/aw/co
- For ATVM run approvals, treat `approve` as run-with-watcher and `approve without watcher` as run-without-watcher.
- Treat git/commit requests as a separate approval gate.
- Follow `/home/aw/code/cds/git-guide.md` for commit-request handling, including the rule that phrases such as `create me a git`, `create a git`, `create a git description`, `make me a git`, `make a git`, `make me a git description`, `create me a git description`, and close variations are prepare-only until the operator explicitly approves the displayed commit command.
- Never execute `git push` from the assistant for this workspace.
- After creating a local commit, stop and give the operator the exact manual push command reference, defaulting to `git push origin main` unless they explicitly ask for a different remote or branch.
- Do not treat `approve` after a commit as permission to push; pushing requires separate explicit wording and still remains manual-reference-only unless the operator explicitly overrides this workspace rule.
- After `cmc-templates.py`, always verify that the generated spec files and the config `specPattern` still include every requested VM before starting `run-sorry-cypress.py`.
- If any requested VM is missing after template generation, stop and report the mismatch instead of launching the runner.
- When the watcher is requested, start the watcher before `run-sorry-cypress.py`.

10
atvm/docs/automation/run-learnings.md
View File

@@ -373,3 +373,13 @@ This file stores run-specific examples only when a run produced a new learning r
- When grouped XML lacks explicit host testcase results, recover grouped host status from the per-host reporter JSON or equivalent detailed artifact.
- Carry through the real `failures`, `pending`, and failure message from that host artifact instead of assuming `PASS completed`.
- If a correction post is needed because stale or reconstructed state was wrong, mark it explicitly as a correction that supersedes the earlier result.
## Run Learning: 2026-03-30 (Git push must stay manual even after commit approval)
- Observed failure mode:
- After creating a requested local commit, the assistant treated a later `approve` as permission to run `git push`.
- The operator expectation was stricter: the assistant should stop at the local commit and only provide the manual push command reference.
- Action for future runs:
- Treat commit creation and push as separate gates.
- Never execute `git push` for this workspace unless the operator explicitly overrides the workspace rule.
- After creating a local commit, provide the manual push command reference only, defaulting to `git push origin main` unless the operator explicitly asks for a different remote or branch.
- Do not interpret a generic `approve` after a commit as push approval.