anthony.wen/cds-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Require explicit confirmation for reboot plugin both

Browse Source
This commit is contained in:
anthony.wen
2026-03-30 20:20:15 -04:00
parent dec13a4667
commit e8353dc9a9
3 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
atvm/docs/automation/guide.md
View File

@@ -32,6 +32,9 @@ Run ATVM CMC automation tests on the designated automation VM without unintended
- For multiple VMs in same distro, use distro-scoped filtering (`--containsVm`) instead of long explicit VM lists.
- Always include `--ignore_force_shutdown` on `cmc-templates.py` commands unless the operator explicitly asks not to.
- Default to `--use_specified_plugin iscsi` unless the operator explicitly requests a different plugin.
- For `cmc-reboot`, treat `--use_specified_plugin both` as an exception case that requires an extra confirmation.
- When `cmc-reboot` is planned with `--use_specified_plugin both`, warn that FC+iSCSI together may hit a "chicken before the egg" timing problem where iSCSI disks are not attached before mTDI / CMC services start.
- For `cmc-reboot`, prefer `--use_specified_plugin fc` or `--use_specified_plugin iscsi` unless the operator explicitly reconfirms that `both` is really intended after seeing that warning.
- Before preparing a new run, always check whether automation is already running.
- Always report whether automation is currently running.
- If running, ask whether to terminate; terminate only with explicit approval.
@@ -195,10 +198,11 @@ Before any new automation request:
12. If any requested VM is missing from the generated files or `specPattern`, stop and report the mismatch instead of launching the runner.
13. Treat displayed commands as a review gate: do not execute either command until the operator has had a chance to review them and explicitly approve.
14. If the operator asks to change plugin, config, filters, build name, Gold Disk, or scope after commands are shown, discard the old plan, show the revised commands, and wait for new approval.
15. If monitoring was not requested, report immediate success/failure for each command.
16. If monitoring was requested, keep monitoring until completion and report final outcome.
17. When the watcher is requested, launch the watcher before `run-sorry-cypress.py`.
18. Do not start the runner before the watcher, because the watcher helper clears stale `/tmp/<build-name>.log` and can delete the fresh live runner log if the runner starts first.
15. If the planned command is `cmc-reboot` with `--use_specified_plugin both`, add the FC+iSCSI timing warning to the review message and require explicit confirmation that `both` is intended before execution.
16. If monitoring was not requested, report immediate success/failure for each command.
17. If monitoring was requested, keep monitoring until completion and report final outcome.
18. When the watcher is requested, launch the watcher before `run-sorry-cypress.py`.
19. Do not start the runner before the watcher, because the watcher helper clears stale `/tmp/<build-name>.log` and can delete the fresh live runner log if the runner starts first.
## Requested Test Style
When asked for one VM or a VM set:

10
atvm/docs/automation/run-learnings.md
View File

@@ -426,3 +426,13 @@ This file stores run-specific examples only when a run produced a new learning r
- If this failure recurs, treat it as a host/storage investigation first, not just a watcher-formatting issue.
- Check whether the FC reboot-validation step actually created `diskname2Reboot.md5` on `/root/tmp/fcDisk` before the md5 verification step ran.
- Check whether repeated iSCSI auth failures or multipath churn during the same boot window are interfering with the expected disk/file state.
## Run Learning: 2026-03-30 (`cmc-reboot` with Pure `both` needs an explicit warning/confirmation gate)
- Observed operator requirement:
- For reboot runs, using both FC and iSCSI together is not a normal default choice.
- There may be a "chicken before the egg" timing problem where iSCSI disks are not attached before mTDI / CMC services start.
- The operator wants `both` on `cmc-reboot` to trigger a warning and an explicit reconfirmation instead of being treated like a routine plugin selection.
- Action for future runs:
- If a planned `cmc-reboot` command includes `--use_specified_plugin both`, call out the FC+iSCSI timing risk before execution.
- Ask the operator to explicitly confirm that `both` is really intended for that reboot run.
- Otherwise prefer `fc` or `iscsi`, but not both.