Tighten ATVM completed-run status verification
This commit is contained in:
@@ -76,6 +76,14 @@ Run ATVM CMC automation tests on the designated automation VM without unintended
|
||||
- Do not treat the existence of a per-host reporter artifact by itself as proof that the host passed.
|
||||
- For categorized grouped recovery, prefer the matching per-host reporter JSON or mochawesome result and carry through the real `failures`, `pending`, and failure message instead of assuming `PASS completed`.
|
||||
- If grouped XML only contains `check-xml-files.ts`, cross-check the grouped result against the per-host reporter artifacts before posting or repeating status for that grouped sub-run.
|
||||
- Treat saved watcher state under `/var/lib/atvm-run-watcher/<build>/state.json` as cached status only.
|
||||
- For completed-run verification, confirm in this order:
|
||||
- launch log under `/tmp/<build>.launch.log`
|
||||
- matching `cmcReporter` artifacts
|
||||
- `Cloud Run Finished` summary and Currents URL
|
||||
- saved watcher state only as a comparison layer
|
||||
- If saved watcher state disagrees with the launch log or with a replay of the exact artifacts through the current watcher code, treat the saved state as stale and do not use it as the reported result.
|
||||
- Never confirm a completed run from `state.json` alone.
|
||||
|
||||
Typical sequence:
|
||||
1. Build the exact `cmc-templates.py` and `run-sorry-cypress.py` commands for the request.
|
||||
@@ -88,6 +96,13 @@ Typical sequence:
|
||||
8. If the watcher is approved, start the watcher before launching `run-sorry-cypress.py`.
|
||||
9. Run `run-sorry-cypress.py` with the matching approved config and build name.
|
||||
|
||||
Completed-run verification sequence:
|
||||
1. Read the launch log for the build.
|
||||
2. Inspect the matching reporter artifacts for the relevant host(s).
|
||||
3. Use the `Cloud Run Finished` summary and Currents URL as the final parent-run check when present.
|
||||
4. Compare that result against saved watcher state.
|
||||
5. If there is any disagreement, replay the exact artifacts through the current watcher code in an isolated temp state directory before confirming the result.
|
||||
|
||||
## Config File / Gold Disk Mapping
|
||||
- `cypress.atvm-config-gold.ts` -> Gold Disk 1
|
||||
- `cypress.atvm-config-gold-2.ts` -> Gold Disk 2
|
||||
|
||||
Reference in New Issue
Block a user