From b1b7e89449447562062f51424d26fe8ba92cde26 Mon Sep 17 00:00:00 2001
From: "anthony.wen" <awen01@gmail.com>
Date: Mon, 30 Mar 2026 20:26:08 -0400
Subject: [PATCH] Default ATVM template runs to test partition

---
 atvm/AGENTS.md                        | 1 +
 atvm/docs/automation/guide.md         | 4 +++-
 atvm/docs/automation/run-learnings.md | 7 +++++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/atvm/AGENTS.md b/atvm/AGENTS.md
index 628244c..83576ac 100644
--- a/atvm/AGENTS.md
+++ b/atvm/AGENTS.md
@@ -51,6 +51,7 @@ This file defines how to operate and maintain the ATVM workspace in `/home/aw/co
 - Default Mattermost status destination config: `/home/aw/code/cds/.env.credentials.local`
 - Default plugin: `--use_specified_plugin iscsi`
 - Always include `--ignore_force_shutdown` unless explicitly told not to.
+- Always include `--test_partition` unless explicitly told not to.
 - Default config family: `gold`
 - Do not auto-add the maintained `--exclude_partial_match` blacklist when the operator explicitly targets named VMs with `--specify_vms`.
 - Even for explicit `--specify_vms` requests, first check whether any requested VM is on the maintained blacklist and stop if it is.
diff --git a/atvm/docs/automation/guide.md b/atvm/docs/automation/guide.md
index c041002..1b6d919 100644
--- a/atvm/docs/automation/guide.md
+++ b/atvm/docs/automation/guide.md
@@ -31,6 +31,7 @@ Run ATVM CMC automation tests on the designated automation VM without unintended
 - `--build_name` must not contain spaces; use `-` between words.
 - For multiple VMs in same distro, use distro-scoped filtering (`--containsVm`) instead of long explicit VM lists.
 - Always include `--ignore_force_shutdown` on `cmc-templates.py` commands unless the operator explicitly asks not to.
+- Always include `--test_partition` on `cmc-templates.py` commands unless the operator explicitly asks not to.
 - Default to `--use_specified_plugin iscsi` unless the operator explicitly requests a different plugin.
 - For `cmc-reboot`, treat `--use_specified_plugin both` as an exception case that requires an extra confirmation.
 - When `cmc-reboot` is planned with `--use_specified_plugin both`, warn that FC+iSCSI together may hit a "chicken before the egg" timing problem where iSCSI disks are not attached before mTDI / CMC services start.
@@ -127,7 +128,7 @@ Completed-run verification sequence:
 
 ## Command Pattern
 ```bash
-python3 cmc-templates.py --template <template> --ignore_force_shutdown --config_file_path ./<config-file> --use_specified_plugin iscsi [template options or explicit plugin override...]; \
+python3 cmc-templates.py --template <template> --ignore_force_shutdown --test_partition --config_file_path ./<config-file> --use_specified_plugin iscsi [template options or explicit plugin override...]; \
 python3 ./run-sorry-cypress.py --config_file <config-file> --build_name <hyphenated-description-no-spaces> [--categorize]
 ```
 
@@ -210,6 +211,7 @@ When asked for one VM or a VM set:
 - choose correct config file for intended Gold Disk,
 - default to a config filename containing `gold` unless the operator explicitly says otherwise,
 - always include `--ignore_force_shutdown` on the template-generation command unless the operator explicitly overrides that default,
+- always include `--test_partition` on the template-generation command unless the operator explicitly overrides that default,
 - default to `--use_specified_plugin iscsi` unless the operator explicitly requests another plugin or the template does not use plugin selection,
 - use a descriptive `--build_name` without Gold Disk IDs.
 
diff --git a/atvm/docs/automation/run-learnings.md b/atvm/docs/automation/run-learnings.md
index d32ad84..2045547 100644
--- a/atvm/docs/automation/run-learnings.md
+++ b/atvm/docs/automation/run-learnings.md
@@ -436,3 +436,10 @@ This file stores run-specific examples only when a run produced a new learning r
   - If a planned `cmc-reboot` command includes `--use_specified_plugin both`, call out the FC+iSCSI timing risk before execution.
   - Ask the operator to explicitly confirm that `both` is really intended for that reboot run.
   - Otherwise prefer `fc` or `iscsi`, but not both.
+
+## Run Learning: 2026-03-30 (Default `--test_partition` on ATVM template commands)
+- Observed operator requirement:
+  - The operator wants `--test_partition` included on ATVM test-template commands by default unless they explicitly say otherwise.
+- Action for future runs:
+  - Add `--test_partition` to `cmc-templates.py` commands by default.
+  - Omit it only when the operator explicitly asks not to use it.