anthony.wen/cds-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix atvm watcher-backed run launch sequence

Browse Source 
Execute the template step before starting watcher-backed ATVM runs.

- run --template-command synchronously in start-atvm-run.sh
- write template output to /tmp/<build>.launch.log
- stop before watcher/runner startup if template generation fails
- document the corrected wrapper behavior in watcher-service docs
- record the stale specPattern failure mode in automation run learnings
This commit is contained in:
anthony.wen
2026-04-29 12:14:55 -04:00
parent 2832ea4175
commit 9673d769e2
4 changed files with 46 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
atvm/docs/automation/run-learnings.md
View File

@@ -9,6 +9,15 @@ This file stores run-specific examples only when a run produced a new learning r
## Current State
- No run-learning entries recorded yet from `guide.md` source material.
## Run Learning: 2026-04-29 (Combined watcher wrapper must execute template generation before runner startup)
- Observed failure mode:
- A watcher-backed `start-atvm-run.sh` launch for `cmc-migrateops-compute-migration` started `run-sorry-cypress.py` without ever running the approved `cmc-templates.py` command.
- The wrapper passed `--template-command` into watcher metadata only, so the runner consumed stale controller config state and started against a previous `specPattern` pointing at `atvm121-ubuntu24.04`.
- Action for future runs:
- The combined watcher wrapper must execute `--template-command` synchronously before watcher and runner startup.
- Write the template phase output to `/tmp/<build>.launch.log` so template activity is preserved separately from the live runner log.
- If the template step fails, stop immediately and do not start the watcher or the runner.
## Run Learning: 2026-04-24 (Categorized watcher false-PASS guardrail)
- Observed failure mode:
- A categorized compute-migration run was incorrectly reported as `PASS` for `atvm121-ubuntu24.04` even though the actual Ubuntu grouped sub-run failed.