anthony.wen/cds-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Harden ATVM watcher artifact scanning

Browse Source 
- skip report artifacts that disappear during watcher post-processing
- use safe mtime handling for XML and mochawesome discovery
- prevent watcher crashes from transient FileNotFoundError races
This commit is contained in:
anthony.wen
2026-04-15 12:06:33 -04:00
parent 32ff90ce74
commit 6334fecffa
1 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
atvm/watcher-service/atvm_run_watcher.py
View File

@@ -607,8 +607,8 @@ def extract_failure_from_mochawesome(
return None return None
candidates = sorted( candidates = sorted(
mochawesome_dir.glob(f"*{build_name}*.html"), existing_paths(mochawesome_dir.glob(f"*{build_name}*.html")),
key=lambda path: (path.stat().st_mtime, 0 if path.name.endswith("_001.html") else 1), key=lambda path: (safe_mtime(path), 0 if path.name.endswith("_001.html") else 1),
reverse=True, reverse=True,
) )
host_pattern = re.escape(host) host_pattern = re.escape(host)
@@ -770,8 +770,8 @@ def collect_host_results(
results: Dict[str, HostResult] = {} results: Dict[str, HostResult] = {}
if not xml_dir.exists(): if not xml_dir.exists():
return results return results
for xml_path in sorted(xml_dir.glob("test-result-*.xml"), key=lambda p: p.stat().st_mtime): for xml_path in sorted(existing_paths(xml_dir.glob("test-result-*.xml")), key=safe_mtime):
xml_mtime = datetime.fromtimestamp(xml_path.stat().st_mtime, tz=timezone.utc) xml_mtime = datetime.fromtimestamp(safe_mtime(xml_path), tz=timezone.utc)
if xml_mtime < run_started_at: if xml_mtime < run_started_at:
continue continue
if run_ended_at and xml_mtime >= run_ended_at: if run_ended_at and xml_mtime >= run_ended_at:
@@ -831,6 +831,17 @@ def reporter_artifact_run_timestamp(artifact_path: Path) -> Optional[datetime]:
return None return None
def safe_mtime(path: Path) -> float:
try:
return path.stat().st_mtime
except FileNotFoundError:
return 0.0
def existing_paths(paths) -> List[Path]:
return [path for path in paths if path.exists()]
def collect_latest_host_reporter_artifact( def collect_latest_host_reporter_artifact(
reporter_root: Path, reporter_root: Path,
expected_hosts: List[str], expected_hosts: List[str],
@@ -1095,8 +1106,8 @@ def find_check_xml_end(
if not xml_dir.exists(): if not xml_dir.exists():
return None return None
latest: Optional[datetime] = None latest: Optional[datetime] = None
for xml_path in sorted(xml_dir.glob("test-result-*.xml"), key=lambda p: p.stat().st_mtime): for xml_path in sorted(existing_paths(xml_dir.glob("test-result-*.xml")), key=safe_mtime):
xml_mtime = datetime.fromtimestamp(xml_path.stat().st_mtime, tz=timezone.utc) xml_mtime = datetime.fromtimestamp(safe_mtime(xml_path), tz=timezone.utc)
if xml_mtime < started_at: if xml_mtime < started_at:
continue continue
if ended_at and xml_mtime >= ended_at: if ended_at and xml_mtime >= ended_at:
@@ -1792,8 +1803,8 @@ def discover_categorized_subruns(
if xml_dir.exists(): if xml_dir.exists():
prefix = f"test-result-{build_name}-" prefix = f"test-result-{build_name}-"
for xml_path in sorted(xml_dir.glob(f"{prefix}*.xml"), key=lambda p: p.stat().st_mtime): for xml_path in sorted(existing_paths(xml_dir.glob(f"{prefix}*.xml")), key=safe_mtime):
xml_mtime = datetime.fromtimestamp(xml_path.stat().st_mtime, tz=timezone.utc) xml_mtime = datetime.fromtimestamp(safe_mtime(xml_path), tz=timezone.utc)
if xml_mtime < started_at: if xml_mtime < started_at:
continue continue
raw_display_name = xml_path.stem[len("test-result-"):] raw_display_name = xml_path.stem[len("test-result-"):]